Skip to content

Conversation

@aduth
Copy link
Member

@aduth aduth commented May 30, 2018

This pull request seeks to remove deprecations slated for removal in the upcoming 3.0.0 release.

Specifically, this includes:

  • Block API: wp.blocks.registerCoreBlocks removed
  • RichText: Blind TinyMCE event forwarding removed

See: https://wordpress.org/gutenberg/handbook/reference/deprecated/#3-0-0

Testing instructions:

Verify that there are no regressions in impacted behavior, and importantly that no references to deprecated behaviors exist in core code.

@aduth aduth added [Feature] Block API API that allows to express the block paradigm. Framework Issues related to broader framework topics, especially as it relates to javascript [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable labels May 30, 2018
@aduth aduth added this to the 3.0 milestone May 30, 2018
'wp-blob',
'wp-blocks',
'wp-components',
'wp-core-data',
Copy link
Member

@gziolo gziolo May 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that core-blocks no longer depends on deprecated.

import { __ } from '@wordpress/i18n';
import { moment } from '@wordpress/date';
import { deprecated } from '@wordpress/utils';
import deprecated from '@wordpress/deprecated';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I included this fix to avoid double warning :)

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Block API API that allows to express the block paradigm. [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable Framework Issues related to broader framework topics, especially as it relates to javascript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants