Skip to content

Add wp-env SPX profiler option #70693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nerrad merged 8 commits into from
Aug 26, 2025
Merged

Add wp-env SPX profiler option #70693

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a9c5a47
Changes from background composer bc-8937f5ee-00f5-4b89-8d22-7c1930bce6dd
cursoragent Jul 7, 2025
a03cd39
fixing configuration of spx in config
nerrad Jul 11, 2025
407630e
only execute with non cli service
nerrad Jul 12, 2025
af310d7
install missing dependency
nerrad Jul 12, 2025
bfb2e2a
fix linting errors
nerrad Jul 12, 2025
35a0a0f
fix linting and remove superfluous test
nerrad Jul 12, 2025
f89942b
split out apt-get commands.
nerrad Aug 11, 2025
9fe6a4c
Use simpler check for value.
nerrad Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
install missing dependency
  • Loading branch information
@nerrad
nerrad committed Jul 12, 2025
commit af310d7945615fa7577c9142ff2e2d524d6ed598
2 changes: 1 addition & 1 deletion packages/env/lib/init-config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ function getSpxConfig( spxMode = 'off', phpVersion, service ) {

return `
# Install SPX profiler
RUN apt-get update && apt-get install -y git
RUN apt-get update && apt-get install -y git zlib1g-dev
Copy link
Member

@jsnajdr jsnajdr Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are existing usages of apt-get in this init-config.js file and they always run as apt-get -qy, i.e., be quiet and say yes to everything.

It would be also nicer if the two apt-get commands ran as independent RUN lines.

RUN cd /tmp && git clone https://github.com/NoiseByNorthwest/php-spx.git
RUN cd /tmp/php-spx && git checkout release/latest
RUN cd /tmp/php-spx && phpize && ./configure && make && make install
Expand Down
Loading