Block Editor: Update conditions for displaying the empty block inserter #70897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
Mamaduka
force-pushed
the
update/empty-block-appender-conditions
branch
from
e2cfbc1 to
98a82e7
Compare
|
Size Change: +9 B (0%) Total Size: 1.92 MB
ℹ️ View Unchanged
|
Mamaduka
force-pushed
the
update/empty-block-appender-conditions
branch
2 times, most recently
from
3376c50 to
ad063a9
Compare
Mamaduka
requested review from
ajitbohra,
ellatrix and
fabiankaegy
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
force-pushed
the
update/empty-block-appender-conditions
branch
from
ad063a9 to
9a3328d
Compare
|
Flaky tests detected in 9a3328d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17398389697
|
andrewserong
approved these changes
Sep 4, 2025
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
Code-wise this looks like a good and straightforward change, and UX-wise I really like this as it (possibly subjectively) improves the state for things like a freshly inserted cover block, where we show an inserter rather than the block toolbar now:
| Trunk | This PR |
|---|---|
 |
 |
This sounds like a good idea to me, so I'm going to give it the ✅, but feel free to seek a second opinion if you need design feedback on the desired UX at all.
LGTM 👍
| name: 'Select parent block: Cover', | ||
| } ) | ||
| ); | ||
| await selectBlock( 'Block: Cover' ); |
Contributor
There was a problem hiding this comment.
Ah, so this changes the state for when we're within a freshly inserted Cover block, too, where there's no block toolbar visible, but we now see the inserter:
That feels like an improvement to the default state of the Cover block to me 👍
Member
Author
|
Thanks for testing and the review, @andrewserong! Let's merge it and see what users think about it. |
This was referenced Dec 10, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #33143.
Closes #48806.
Related #70764, #70903.
PR relaxes conditions for displaying an
EmptyBlockInserterinserter. The user should be able to replace the empty default block if it doesn't cause a content loss.Only changes to attributes with
role: contentor block bindings are considered block modifications, rather than any attribute changes like block styling.Note
This introduces a small behavior change for the default block (Paragraph), where the toolbar isn't visible until you add the content. Previously, it would become visible after changing the styling. Hence, the testing changes in this PR.
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast