Social: Document guidelines and extensibility #70961
Conversation
Mamaduka
added
[Type] Developer Documentation
|
|
||
| ## Adding custom social icons | ||
|
|
||
| Starting from WordPress 6.9, it's possible to add custom social icons to your site. Here's an example plugin: https://github.com/wptrainingteam/devblog-custom-social-icons. |
There was a problem hiding this comment.
We could include the dev block post when it's published.
There was a problem hiding this comment.
For now I would link to the PR that makes it possible in Gutenberg. And once the dev blog post is published add it to the readme. Although the example plugin is certainly educational it only goes together with the Developer Blog post.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
|
||
| ## Adding custom social icons | ||
|
|
||
| Starting from WordPress 6.9, it's possible to add custom social icons to your site. Here's an example plugin: https://github.com/wptrainingteam/devblog-custom-social-icons. |
There was a problem hiding this comment.
For now I would link to the PR that makes it possible in Gutenberg. And once the dev blog post is published add it to the readme. Although the example plugin is certainly educational it only goes together with the Developer Blog post.
|
Thanks, @bph! A small note: I've used the oEmbed provider guidelines as a template. Some of your suggestions could apply there as well. |
|
@bph, updated the new guidelines based on your feedback. Thank you! |
priethor
left a comment
priethor
left a comment
There was a problem hiding this comment.
Now that we have a readme file, should we add a section with a list of supported services? We have a file for each service, but is there any edge case (like Twitter and X) that it could help clarify?
|
I worry that keeping an image with all the icons needs to be redone every time a variation is added/removed/updated, even if it's not common 😅 . I was thinking of adding a simple list with each service, a link, and maybe the version it was introduced at? |
This might be a bit hard to track down 😅 |
|
I'm only thinking out loud, it's fine otherwise 😆 |
priethor
left a comment
priethor
left a comment
There was a problem hiding this comment.
Looks good to me after addressing the feedback; my suggestion is not a blocker.
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: bph <[email protected]> Co-authored-by: priethor <[email protected]>
What?
Closes #70774.
PR adds guidelines for including new social services in the core and a section about extensibility.
The guideline borrows from the core oEmbed provider "rules" - https://make.wordpress.org/core/handbook/contribute/design-decisions/#adding-new-oembed-providers.
Testing Instructions
Review the proposed documentation.