-
Notifications
You must be signed in to change notification settings - Fork 4.7k
DataViews: Add data picker functionality #70971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
cc87232
Create DataPicker component as a sibling to DataViews
talldan 2afca04
Remove DataPicker components
talldan f0e24d8
Add simple isPicker prop to dataviews, and use it to start configurin…
talldan d571cdb
Split into separate components
talldan 67b13c2
Limit the type of views that can be provided to DataViews and DataVie…
talldan 7f4f8aa
Switch to isPicker prop in the view layout config for filtering view …
talldan 487d355
Fix type name
talldan 45b1896
Share layout component between picker and regular dataviews
talldan 817587b
Fix story and broken css
talldan 1341b9a
Extract grid styling to a shared component
talldan 23472bf
Switch back to a single View type
talldan 103c689
Fix config type after rebase
talldan 69cf7e2
Use context for `isPicker` rather than a prop to the layout component…
talldan 5e0c8c9
Remove todo from test
talldan 8827304
Allow custom content in footer and use multiselect property of picker…
talldan 70e4390
Adjust footer styling and update story
talldan c933dfa
Update tests
talldan 6d2dc02
Use actions API
talldan dc5c179
Make a controlled selection required for DataViewsPicker
talldan a8b9552
Update docs
talldan fc34b2e
Add changelog entry
talldan 20dc4ae
Fix BulkSelectionCheckbox
talldan 55f530b
Share the PreviewSizePicker between grid and pickerGrid
talldan 9838725
Undo change to defaultLayouts
talldan 3219ca1
Tidy up main DataViewsPicker component
talldan 2a65f80
Remove extra tab stop on fields caused by tooltip
talldan 274b28b
Remove note about importing DataViews
talldan 403a8fe
Remove picker internal selection state
talldan 568fb63
Align footer buttons to the right
talldan 984ed47
Update action button style. Make non-primary button a tertiary varian…
talldan b5f8866
Align bulk selection to the left on mobile
talldan 913601e
Remove outdated comment
talldan ef151d3
Remove change that was reverted in trunk after components diverged (s…
talldan 2f4e5d8
Remove selection property from action type
talldan eabd7fb
Remove promise return type from ActionButton
talldan 69490be
Remove unused props for picker
talldan ffd6e09
Limit actions to ActionButton via type
talldan 73d5182
Update wrapper classname
talldan 05f1e00
Filter picker/non-picker layouts in main DataViews components
talldan e71299b
Move label prop to DataViewsPicker instead of View
talldan b948c7a
Rename label to itemListLabel
talldan 383bed7
Add missing changes to ViewPickerBaseProps
talldan 9bca0d4
Update label name in docs
talldan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Rename label to itemListLabel
- Loading branch information
commit b948c7a08739843d92daa96bbc55bc89f2517f7c
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.