Skip to content

Post Date block: Address feedback #70982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ockham merged 3 commits into from
Jul 30, 2025
+6 −4
Merged

Post Date block: Address feedback #70982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
20c4a8f
Block bindings: Translate core/post-data source labels
ockham Jul 30, 2025
c6b6a9a
Use epoch to compare dates
ockham Jul 30, 2025
ac79839
Add to backport changelog
ockham Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion backport-changelog/6.9/9299.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
https://github.com/WordPress/wordpress-develop/pull/9299

* https://github.com/WordPress/gutenberg/pull/70585
* https://github.com/WordPress/gutenberg/pull/70585
* https://github.com/WordPress/gutenberg/pull/70982
2 changes: 1 addition & 1 deletion lib/compat/wordpress-6.9/post-data-block-bindings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ function gutenberg_block_bindings_post_data_get_value( array $source_args, $bloc

if ( 'modified' === $source_args['key'] ) {
// Only return the modified date if it is later than the publishing date.
if ( get_the_modified_date( 'Ymdhi', $post_id ) > get_the_date( 'Ymdhi', $post_id ) ) {
if ( get_the_modified_date( 'U', $post_id ) > get_the_date( 'U', $post_id ) ) {
return esc_attr( get_the_modified_date( 'c', $post_id ) );
} else {
return '';
Expand Down
5 changes: 3 additions & 2 deletions packages/editor/src/bindings/post-data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/**
* WordPress dependencies
*/
import { __ } from '@wordpress/i18n';
import { store as coreDataStore } from '@wordpress/core-data';

/**
Expand Down Expand Up @@ -41,12 +42,12 @@ function getPostDataFields( select, context ) {
);
dataFields = {
date: {
label: 'Post Date',
label: __( 'Post Date' ),
value: entityDataValues?.date,
type: 'string',
},
modified: {
label: 'Post Modified Date',
label: __( 'Post Modified Date' ),
value: entityDataValues?.modified,
type: 'string',
},
Expand Down
Loading