Hide Cut/Copy commands in Write Mode (contentOnly) #71063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +29 B (0%) Total Size: 1.91 MB
ℹ️ View Unchanged
|
Fixes issue where Cut/Copy/Paste commands were visible in Write Mode when they should be hidden. Write Mode is contentOnly mode where users should only see content-editing capabilities without structural controls. - Added isContentOnly condition to CopyMenuItem for Copy command - Added isContentOnly condition to CopyMenuItem for Cut command - Maintains existing behavior for other menu items
getdave
force-pushed
the
fix/write-mode-cut-copy-commands
branch
from
7fb3109 to
36dba23
Compare
- Update test to expect 4 menu items instead of 6 (Cut and Copy are hidden in Write Mode) - Rename isWriteMode to isContentOnlyWriteMode for better clarity - Fix indentation issues
getdave
added
[Type] Enhancement
Mamaduka
approved these changes
Aug 7, 2025
scruffian
approved these changes
Aug 8, 2025
Contributor
scruffian
left a comment
scruffian
left a comment
There was a problem hiding this comment.
As discussed in the other PRs around write mode, I think we should consolidate this logic into one shared hook that we can use everywhere, but that can be a follow up :)
| openedBlockSettingsMenu: getOpenedBlockSettingsMenu(), | ||
| isContentOnly: | ||
| getBlockEditingMode( firstBlockClientId ) === 'contentOnly', | ||
| isNavigationMode: _isNavigationMode(), |
Contributor
There was a problem hiding this comment.
Do we need this check? isContentOnly should only be true for any block when navigation mode is enabled.
Member
There was a problem hiding this comment.
Container blocks can set editing mode outside the navigation using the templateLock. I guess it depends on whether to hide/show features based on only block editing mode or navigation mode.
Here's a case where both mode checks are needed - #70946.
Contributor
There was a problem hiding this comment.
Hmm that feels like a bug, templateLock is a different thing from editingMode (or it should be).
Member
There was a problem hiding this comment.
Yes, they're different, but both are setting block editing modes, which makes it hard to differentiate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes issue where Cut/Copy/Paste commands were visible in Write Mode when they should be hidden. Write Mode is contentOnly mode where users should only see content-editing capabilities without structural controls.
Why
When users are in Write Mode (contentOnly mode), they should only see content-editing capabilities without interference from structural/formatting controls. The Cut/Copy/Paste commands are structural controls that should be hidden in this mode to provide a cleaner, more focused editing experience.
How
Testing
Screenshots