-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Components: Update gradient-parser from 1.0.2 to 1.1.1 #71186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
139742b to
229b827
Compare
|
Size Change: +689 B (+0.04%) Total Size: 1.91 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in ec3cb7d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/16953870801
|
aduth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question on calc, but LGTM 👍
|
Sorry I haven't tested myself, but potentially closing: |
|
I'd like to merge this PR, and I will also test whether the following issues are resolved:
|
|
I'm sorry, I forgot to add props when merging 🙏 |
What?
This PR updates the version of the
gradient-parserlibrary to allow theGradientPickercomponent to handle more color formats and expressions.Specifically, this PR adds new support for:
Changes between 1.0.2 and 1.1.1
There is no changelog file for this library, but all changes are listed below:
rafaelcaricio/gradient-parser@1.0.2...v1.1.1
Type definition update
DefinitelyTyped/DefinitelyTyped#73447
Why?
Without these supports, values will not be parsed correctly, and colors will not preview correctly.
How?
I updated the relevant functions to correctly handle the new formats and expressions.
Testing Instructions
Launch Storybook and access GradientPicker stories.
Screenshots
HSLA color
Note that
colordconverts HSLA color to RGBA color when rendering.CSS variables