Skip to content

Fields Components: Add missing style resets for fieldset elements #71217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewserong merged 1 commit into from
Aug 15, 2025
Merged

Fields Components: Add missing style resets for fieldset elements #71217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/fields/src/components/create-template-part-modal/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ export function CreateTemplatePartModalContents( {
onChange={ setTitle }
required
/>
<fieldset>
<fieldset className="fields-create-template-part-modal__area-fieldset">
<BaseControl.VisualLabel as="legend">
{ __( 'Area' ) }
</BaseControl.VisualLabel>
Expand Down
7 changes: 7 additions & 0 deletions packages/fields/src/components/create-template-part-modal/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@
z-index: z-index(".fields-create-template-part-modal");
}

.fields-create-template-part-modal__area-fieldset {
// Reset `fieldset` browser defaults.
border: 0;
padding: 0;
margin: 0;
}

.fields-create-template-part-modal__area-radio-group {
border: $border-width solid $gray-600;
border-radius: $radius-small;
Expand Down
5 changes: 5 additions & 0 deletions packages/fields/src/fields/featured-image/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,11 @@
}

fieldset.fields-controls__featured-image {
// Reset `fieldset` browser defaults.
border: 0;
padding: 0;
margin: 0;

.fields-controls__featured-image-container {
border: $border-width solid $gray-300;
border-radius: $radius-small;
Expand Down
6 changes: 6 additions & 0 deletions packages/fields/src/fields/parent/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
.fields-controls__parent {
// Reset `fieldset` browser defaults.
border: 0;
padding: 0;
margin: 0;
}
6 changes: 6 additions & 0 deletions packages/fields/src/fields/password/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
.fields-controls__password {
// Reset `fieldset` browser defaults.
border: 0;
padding: 0;
margin: 0;
}
5 changes: 5 additions & 0 deletions packages/fields/src/fields/slug/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,9 @@
.fields-controls__slug {
// Reset `fieldset` browser defaults.
border: 0;
padding: 0;
margin: 0;

.fields-controls__slug-external-icon {
margin-left: 5ch;
}
Expand Down
7 changes: 7 additions & 0 deletions packages/fields/src/fields/template/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
.fields-controls__template {
// Reset `fieldset` browser defaults.
border: 0;
padding: 0;
margin: 0;
}

.fields-controls__template-modal {
z-index: z-index(".fields-controls__template-modal");
}
Expand Down
2 changes: 2 additions & 0 deletions packages/fields/src/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
@import "./components/create-template-part-modal/style.scss";
@import "./fields/slug/style.scss";
@import "./fields/featured-image/style.scss";
@import "./fields/parent/style.scss";
@import "./fields/password/style.scss";
@import "./fields/template/style.scss";
@import "./fields/title/style.scss";
@import "./fields/pattern-title/style.scss";
Loading