Rename Accordions block to Accordion #71222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikachan
added
[Type] Enhancement
mikachan
requested review from
ajitbohra,
fabiankaegy,
juanmaguitar,
ndiego and
spacedmonkey
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +15 B (0%) Total Size: 1.92 MB
ℹ️ View Unchanged
|
Contributor
|
Thanks @mikachan ! The block names seem more consistent to me this way. Let's see what others think about it. Maybe we should also update the old description “A single accordion that displays a header and expandable content.” for the “Accordion Item” block? |
Member
Author
Yes, good point, maybe something like: "A single accordion item that displays a header and expandable content."? |
|
Renaming 'Accordions' to 'Accordion' to align with the W3C guidelines makes sense. I have to get used to "Accordion Item" as a name for the inner content, because we haven't used the word "Item" before for any other block and we haven't defined globally what an "Item" really is. |
Contributor
|
No strong opinion on my part. It seems the important piece for discoverability is that if you search for "accordion", you'll find it (✅), and that there's a good block preview. |
Member
Author
@hanneslsm We do have "List Item" as an inner block of the List block, so that's similar, but I'd be happy with "Accordion Content" too, as that's aligned with "Post Content" and "Comment Content", and "content" is more descriptive. If no one has any objections, I'll include that name change ("Accordion Item" > "Accordion Content") in this PR, and then we can land this PR in time for the first GB 21.5 release candidate. |
@mikachan True, totally forget about this one! I'm fine with both. |
# Conflicts: # packages/block-library/src/accordion/edit.js
Member
Author
|
I've renamed "Accordion Item" to "Accordion Content": 
If we're mostly in agreement with these name changes, I'd appreciate an approval 🙇 I'm not sure how to handle the failing "Verify Core Backport Changelog" check. I don't think this PR needs a specific Core backport, as this is currently an experimental block. Also, when it's made stable, it will be added to Core as part of the Editor package update in each release rather than an individual backport. Maybe the conditions for this check need to be tweaked so new blocks do not require a backport PR? |
Contributor
You can use the
It seems to be suggested to use the third person that starts with a verb. See: |
t-hamano
added
the
No Core Sync Required
# Conflicts: # packages/block-library/src/accordion-content/icon.js # packages/block-library/src/accordion-content/index.js # packages/block-library/src/accordion/icon.js # packages/icons/src/index.ts # packages/icons/src/library/accordion-content.tsx # packages/icons/src/library/accordion-item.tsx
Member
Author
|
Thanks @t-hamano! I've updated all the Accordion block descriptions to match the guidelines discussed in that issue. |
|
Flaky tests detected in 501f0aa. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17073281030
|
t-hamano
reviewed
Aug 20, 2025
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Almost looks good! Finally, I think the description needs to be standardized: it's Sentence case, not Title Case, and it ends with a period.
- Accordion:
Displays a group of accordion headers and associated expandable content. - Accordion Content:
Displays a section of content in an accordion, including a header and expandable content. - Accordion Header:
Displays an accordion header. - Accordion Panel:
Displays an accordion panel.
P.S. While breaking changes are probably acceptable for now, please note that if these blocks become stable in the future, it will be difficult to change the namespace of the blocks.
Member
Author
t-hamano
approved these changes
Aug 20, 2025
adamsilverstein
pushed a commit
to adamsilverstein/gutenberg
that referenced
this pull request
Aug 20, 2025
* Rename Accordions to Accordion * Rename accordion-item * Update block descriptions * Tweak block descriptions Co-authored-by: mikachan <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: alexandrebuffet <[email protected]> Co-authored-by: hanneslsm <[email protected]> Co-authored-by: jasmussen <[email protected]>
9 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Addresses this comment: #21584 (comment)
cc @alexandrebuffet
This PR renames the recently merged Accordions block (#64119) to "Accordion". This aligns with how this pattern is described by W3C: https://www.w3.org/WAI/ARIA/apg/patterns/accordion/.
Pinging some folks who originally had input on this name in the discussion in the original PR: @jasmussen, @LukaszJaro, @Jabe64, @Nyiriland, @hanneslsm, @MaggieCabrera
This PR also renames the inner block, "Accordion Item", to "Accordion Content". See this discussion for details: #71222 (comment)
Why?
To align more closely with how this pattern is usually described, e.g. https://www.w3.org/WAI/ARIA/apg/patterns/accordion/.
How?
Testing Instructions
Screenshots or screencast