Skip to content

Fix DataViews primary actions horizontal layout consistency #71274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
priethor merged 2 commits into from
Aug 20, 2025
Merged

Fix DataViews primary actions horizontal layout consistency #71274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad57d86
Fix DataViews actions horizontal layout consistency
priethor Aug 20, 2025
5b7b9ff
Update changelog with this fix
priethor Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/dataviews/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
### Bug Fixes

- Do not throw exception when `view.layout.previewSize` is smaller than the smallest available size. [#71218](https://github.com/WordPress/gutenberg/pull/71218)
- Fix actions horizontal layout consistency when all actions are primary. [#71274](https://github.com/WordPress/gutenberg/pull/71274)

## 6.0.0 (2025-08-07)

Expand Down
23 changes: 7 additions & 16 deletions packages/dataviews/src/components/dataviews-item-actions/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,17 +179,6 @@ export default function ItemActions< Item >( {
);
}

// If all actions are primary, there is no need to render the dropdown.
if ( primaryActions.length === eligibleActions.length ) {
return (
<PrimaryActions
item={ item }
actions={ primaryActions }
registry={ registry }
/>
);
}

return (
<HStack
spacing={ 1 }
Expand All @@ -205,11 +194,13 @@ export default function ItemActions< Item >( {
actions={ primaryActions }
registry={ registry }
/>
<CompactItemActions
item={ item }
actions={ eligibleActions }
registry={ registry }
/>
{ primaryActions.length < eligibleActions.length && (
<CompactItemActions
item={ item }
actions={ eligibleActions }
registry={ registry }
/>
) }
</HStack>
);
}
Expand Down
Loading