-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Enable inline comments on published post #71295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable inline comments on published post #71295
Conversation
This reverts commit 63f81c1.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
adamsilverstein
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
@t-hamano does this look ok to you? Do you have any context for why commenting was disabled for published posts previously? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can merge this. IIRC, the condition was temporary.
P.S. Rebasing should restart stalled tests.
…mments-on-published-post
Rebased. |
|
Sorry for the comment after the PR has been merged. This PR unintentionally exposed the block commenting to the template or template parts editor. I think we'll need to somehow disable block comments for any screens or post types where they don't work. See #66377 (comment) for more details. |
|
Maybe support for block comments should be declared on the Post Type level. |
What?
Closes #71245
This PR restores the ability to add block-level comments on published posts. Previously, the functionality was removed in #66583, but this update ensures that users can continue to add comments even after a post has been published.
Why?
There are many use cases where published posts still receive updates or collaborative changes. Without this fix, users cannot add block-level comments once a post is published, which limits collaboration and feedback opportunities.
This PR makes block commenting consistent across draft and published states.
Testing Instructions
wp-admin/admin.php?page=gutenberg-experiments.Testing Instructions for Keyboard
Screenshots or screencast