Skip to content

Modal headings and labels missing editor text color #71311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juanfra merged 14 commits into from
Sep 4, 2025
Merged

Modal headings and labels missing editor text color #71311

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ed155a6
style: update header and content color to $gray-900 for better contrast
kushagra-goyal-14 Aug 22, 2025
143e9ed
chore: update changelog.md
kushagra-goyal-14 Aug 22, 2025
18b8400
chore: update changelog to include modal text color fix
kushagra-goyal-14 Aug 22, 2025
6c4cb8e
chore: correct heading casing in changelog
kushagra-goyal-14 Aug 22, 2025
59c64b6
Merge branch 'trunk' into update/modal-heading-labels-missing-text-color
kushagra-goyal-14 Aug 28, 2025
29a8cf9
style: ensure proper text color for modal headings and content
kushagra-goyal-14 Aug 28, 2025
2520bae
Merge branch 'trunk' into update/modal-heading-labels-missing-text-color
kushagra-goyal-14 Aug 29, 2025
be93c46
style: update changelog and set proper editor text color for modal co…
kushagra-goyal-14 Sep 3, 2025
aad595d
Merge branch 'trunk' into update/modal-heading-labels-missing-text-color
kushagra-goyal-14 Sep 3, 2025
90ce9e5
chore: remove repeated internal in CHANGELOG
kushagra-goyal-14 Sep 3, 2025
d911eb9
Merge branch 'trunk' into update/modal-heading-labels-missing-text-color
kushagra-goyal-14 Sep 3, 2025
a313214
Merge branch 'trunk' into update/modal-heading-labels-missing-text-color
kushagra-goyal-14 Sep 4, 2025
d0b6d7b
chore: add entry to changelog.md
kushagra-goyal-14 Sep 4, 2025
3f0612f
chore: correct pull request reference in changelog for Modal text col…
kushagra-goyal-14 Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
style: update changelog and set proper editor text color for modal co… 
…ntent
  • Loading branch information
@kushagra-goyal-14
kushagra-goyal-14 committed Sep 3, 2025
commit be93c467b217b50d24d30bacf292d62ba2593b8c
3 changes: 1 addition & 2 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,8 @@
### Bug Fixes

- `Tabs`: Ensure font size inheritance for tab buttons in all contexts ([#71346](https://github.com/WordPress/gutenberg/pull/71346)).
### Bug fixes

- `Modal`: Fix modal headings and labels to use proper editor text color instead of wp-admin colors ([#71311](https://github.com/WordPress/gutenberg/pull/71311)).
- `Modal`: Fix modal headings and labels to use proper editor text color instead of wp-admin colors ([#50448](https://github.com/WordPress/gutenberg/pull/71311)).


## 30.2.0 (2025-08-20)
Expand Down
1 change: 0 additions & 1 deletion packages/components/src/modal/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
overflow: hidden;
// Have the content element fill the vertical space yet not overflow.
display: flex;
// Set the proper editor text color for all content within the modal
color: $gray-900;
// Animate the modal frame/contents appearing on the page.
animation-name: components-modal__appear-animation;
Expand Down