Skip to content

Update types of getCurrentPostId #71347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mamaduka merged 2 commits into from
Aug 27, 2025
Merged

Update types of getCurrentPostId #71347

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83fc63d
Update types of getCurrentPostId
kmanijak Aug 26, 2025
7d658bb
Emphasize the post ID first
kmanijak Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update types of getCurrentPostId
  • Loading branch information
@kmanijak
kmanijak committed Aug 26, 2025
commit 83fc63de07cd423e188e628221db0410e5515d6b
2 changes: 1 addition & 1 deletion docs/reference-guides/data/data-core-editor.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ _Parameters_

_Returns_

- `?number`: ID of current post.
- `?(string|number)`: Template slug or current post ID.

### getCurrentPostLastRevisionId

Expand Down
2 changes: 1 addition & 1 deletion packages/editor/src/store/selectors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ export function getCurrentPostType( state ) {
*
* @param {Object} state Global application state.
*
* @return {?number} ID of current post.
* @return {?(string|number)} Template slug or current post ID.
Copy link
Member

@Mamaduka Mamaduka Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @return {?(string|number)} Template slug or current post ID.
* @return {?(string|number)} The current post ID or template slug.

Let's emphasize the post ID.

Copy link
Contributor Author

@kmanijak kmanijak Aug 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Updated in 7d658bb. I swapped types as well so there's more logical order.

Copy link
Member

@Mamaduka Mamaduka Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kmanijak!

*/
export function getCurrentPostId( state ) {
return state.postId;
Expand Down
Loading