Core Data: Include pagination meta while receiving intermediate results #71401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
|
Size Change: +2 B (0%) Total Size: 1.92 MB
ℹ️ View Unchanged
|
tyxla
reviewed
Aug 29, 2025
| totalItems: parseInt( | ||
| response.headers.get( 'X-WP-Total' ) | ||
| ), | ||
| totalPages: 1, |
Member
There was a problem hiding this comment.
Shouldn't this be using X-WP-TotalPages? We could use the totalPages constant from above:
Suggested change
| totalPages: 1, | |
| totalPages, |
Member
Author
There was a problem hiding this comment.
The total pages definition above is used for the loop. The number of pages for unbound queries should be one, as it fetches all results and technically isn't "paginated".
From previous work - #64772.
gutenberg/packages/core-data/src/resolvers.js
Lines 332 to 335 in b5d6d76
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tyxla
approved these changes
Aug 29, 2025
Member
tyxla
left a comment
tyxla
left a comment
There was a problem hiding this comment.
LGTM 👍
Would be interesting to see a unit test for this one, but I can imagine it being a bit tricky to set up.
Member
Author
Yes, it's tricky to do as an actual unit test; we'll have to mock a lot of things, and then the value won't be the same. It has been mentioned a couple of times, but to thoroughly test code data selectors, we need integration tests that mock the API responses. There are a couple of other Core Data issues I plan to address, so I might try to implement integration tests first to avoid accidental regressions. P.S. Failing e2e tests aren't related. I'm going to merge this. |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #66713.
PR updates
getEntityRecordsresolver to include pagination meta while store receives intermediate results.Why?
The
X-WP-Totalheader is available in this case, so there's no need to wait for full resolution to derive and send total items data.It's helpful when an app displays a loading state that uses the currently fetched records and the total number of expected items.
Testing Instructions
This is a bit hard to test manually, so confirm that the changed logic has its merit 😓