Edit Post: Fix misplaced icon on back button #71406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
t-hamano
commented
Aug 29, 2025
Comment on lines
34
to
35
| bottom: 9px + $border-width; // Height of toolbar in edit-post (not edit-site) is 61px tall. | ||
| bottom: 9px; |
Contributor
Author
There was a problem hiding this comment.
This is not directly related to the original issue, but just a minor tweak to make the focus outline square.
| Before | After |
|---|---|
 |
 |
Contributor
There was a problem hiding this comment.
I wonder if replacing all instances of 9px with $grid-unit-10 + $border-width would make it more legible?
t-hamano
force-pushed
the
fix/edit-post-back-button-icon
branch
from
ef3a723 to
cb97497
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @Akhilanandateja, @CreativeDive. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +4 B (0%) Total Size: 1.92 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
Aug 29, 2025
jameskoster
reviewed
Aug 29, 2025
| display: flex; | ||
| align-items: center; | ||
| align-self: stretch; | ||
| justify-content: center; |
Contributor
There was a problem hiding this comment.
I wonder if this should be added to the Button component 🤔
Contributor
Author
There was a problem hiding this comment.
I know there are plenty of custom styles for centering button text, so changing the default alignment might certainly be worth looking into. I may have seen an issue somewhere suggesting that.
6 tasks
Contributor
|
Nice one, thank you! |
|
Flaky tests detected in 3524488. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17320165303
|
Member
|
I am going to go ahead and merge this as seems like it is ready to go, thanks everyone. |
Contributor
Author
|
@karmatosed, When you merge a PR in the future, it's a good idea to add the props to the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71403
What?
This PR fixes the misplaced icon on the back button.
Why?
In #60729, we unified the header height to 64px in all editors. As a result, the back button size increased from 60px to 64px, creating new internal space, but there was no CSS to align the icon horizontally.
Testing Instructions
Open the post editor and hover or focus on the back button.
Screenshots or screencast