-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Accordion Content, Header, Panel: Remove example field #71407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +5 B (0%) Total Size: 1.92 MB
ℹ️ View Unchanged
|
|
Should this be part of #71365? |
Mamaduka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this ✅
mikachan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Related: #71354
What?
Since the Accordion Content, Header, and Panel block cannot be inserted at the root level of the editor, it doesn't make sense to show the example on Storybook, and the block preview in the sidebar.
How?
Removes
examplesfield. This field is used to determine whether the block preview is to be rendered.Testing Instructions
Screenshots or screencast
Before
After