Inserter: Fix InserterListbox rendering for React 19
#71410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +19 B (0%) Total Size: 1.92 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Aug 29, 2025
Member
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
Thanks, @tyxla! I've not noticed any issues when testing locally.
We're creating a component to receive the ref, since Fragment can't receive refs and React will throw an error.
This might change in the future - facebook/react#32465.
Member
Author
Yeah, however, it's necessary for the time being. Luckily, it's a pretty cheap one. |
Member
Author
|
@Mamaduka mind if I ship with the e2e failures? It's the one that fails in every other PR and is not related. |
Member
|
Yes, let's merge this. The e2e failures aren't related, I'm trying to debug those separately, but no luck so far :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes an error during
InserterListboxrendering when using React 19.Why?
To prepare for React 19 compatibility and to fix an error when using React 19.
See #71336 for the full effort.
See #61521 for the PR where the changes came from.
How?
We're creating a component to receive the ref, since
Fragmentcan't receive refs and React will throw an error.The change is harmless and won't have any effect in React 18 since the error will be thrown only with React 19.
We're pulling in a part of #61521 to be landed separately.
Testing Instructions
To actually witness the error in React 19:
git revert a72061d862c923d5339c14f5a2ebf77a2441db02and go through the above testing instructions.Testing Instructions for Keyboard
None
Screenshots or screencast