-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Block Comments: use TextareaAutosize for comment field #71424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Comments: use TextareaAutosize for comment field #71424
Conversation
|
I wish |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I think rebasing went bit crazy 😅 |
Yeah, I noticed. oops, not sure what happened! I'm going back to my usual pattern of merging trunk until I figure that out. I was just asking you about it in the other thread. |
- added rows= { 4 }
- set maxRows to 20
- added label using VisuallyHidden component
67cecf6 to
1e104c5
Compare
Fixed the branch, ready for review again @Mamaduka. |
Mamaduka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @adamsilverstein!
Did you figure out what the reason was?
@Mamaduka I think what happened is I was resolving conflicts when rebasing on trunk, then inadvertently pushed the branch while still in the unresolved state. To fix the issue I aborted the rebase, did the rebase again completing it this time and force pushed. |
What?
Makes the comment input resize to the contained text.
Closes: #71425
Why?
Currently the comment box has a fixed size. Instead, the textarea should scale to the contained comment text with a minimum size similar to the current display.
How?
Use the TextareaAutosize component.
Testing Instructions
expected results:
The text area should expand to show the full text.
Testing Instructions for Keyboard
same