Skip to content

Conversation

@adamsilverstein
Copy link
Member

@adamsilverstein adamsilverstein commented Aug 30, 2025

What?

Makes the comment input resize to the contained text.

Closes: #71425

Why?

Currently the comment box has a fixed size. Instead, the textarea should scale to the contained comment text with a minimum size similar to the current display.

How?

Use the TextareaAutosize component.

Testing Instructions

  1. make sure inline commenting experiment is enabled
  2. leave a comment that is much larger than the input box

expected results:
The text area should expand to show the full text.

Testing Instructions for Keyboard

same

@adamsilverstein adamsilverstein added [Type] Enhancement A suggestion for improvement. Collaborative Workflows Phase 3 of the Gutenberg roadmap around all-things related to collaborative workflows labels Aug 30, 2025
@Mamaduka Mamaduka changed the title Try/text area autosize Block Comments: Try textarea autosize Sep 2, 2025
@Mamaduka
Copy link
Member

Mamaduka commented Sep 2, 2025

I wish field-sizing had better browser support so that we could drop JS hacks.

@adamsilverstein adamsilverstein marked this pull request as ready for review September 7, 2025 04:06
@github-actions
Copy link

github-actions bot commented Sep 7, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: hbhalodia <[email protected]>
Co-authored-by: adamsilverstein <[email protected]>
Co-authored-by: Mamaduka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-project-automation github-project-automation bot moved this to 🔎 Needs Review in WordPress 6.9 Editor Tasks Sep 10, 2025
@adamsilverstein adamsilverstein changed the title Block Comments: Try textarea autosize Block Comments: use TextareaAutosize for comment field Sep 11, 2025
@adamsilverstein adamsilverstein requested review from Mamaduka and removed request for ajitbohra, ellatrix, fabiankaegy, nerrad and swissspidy September 11, 2025 04:08
@Mamaduka
Copy link
Member

I think rebasing went bit crazy 😅

@adamsilverstein
Copy link
Member Author

adamsilverstein commented Sep 11, 2025

I think rebasing went bit crazy 😅

Yeah, I noticed. oops, not sure what happened! I'm going back to my usual pattern of merging trunk until I figure that out. I was just asking you about it in the other thread.

@adamsilverstein
Copy link
Member Author

I think rebasing went bit crazy 😅

Fixed the branch, ready for review again @Mamaduka.

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @adamsilverstein!

Did you figure out what the reason was?

@Mamaduka Mamaduka merged commit eafda03 into WordPress:trunk Sep 11, 2025
68 checks passed
@github-project-automation github-project-automation bot moved this from 🔎 Needs Review to ✅ Done in WordPress 6.9 Editor Tasks Sep 11, 2025
@github-actions github-actions bot added this to the Gutenberg 21.7 milestone Sep 11, 2025
@adamsilverstein
Copy link
Member Author

Did you figure out what the reason was?

@Mamaduka I think what happened is I was resolving conflicts when rebasing on trunk, then inadvertently pushed the branch while still in the unresolved state. To fix the issue I aborted the rebase, did the rebase again completing it this time and force pushed.

@t-hamano t-hamano added [Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting and removed Collaborative Workflows Phase 3 of the Gutenberg roadmap around all-things related to collaborative workflows labels Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Notes Phase 3 of the Gutenberg roadmap around block commenting [Type] Enhancement A suggestion for improvement.

Projects

Development

Successfully merging this pull request may close these issues.

Ensure comment input expands for large text entry

4 participants