Group Block variation:remove variation text color.

[shimotmk]

What?

Group Block variation:Displays variation colors correctly.

Why?

Change the text color attribute from customTextColor to style > color > text.

This attribute change was probably made 5 years ago.
#21037

If you don't think you need text color, remove the color.

How?

Testing Instructions

1. Open a post or page.
2. Hover over the Row block to see the example
3. You'll see that the example text is colored.

Testing Instructions for Keyboard

Screenshots or screencast

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: shimotmk <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: jasmussen <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[t-hamano]

Good catch!

This attribute change was probably made 5 years ago.
#21037

If you don't think you need text color, remove the color.

While a colorized preview is certainly the correct way to go, unfortunately, we have become accustomed to unintentionally uncolorized block previews for many years. Additionally, I think the colorized preview is too prominent.

Personally, I prefer to remove color from the preview. cc @WordPress/gutenberg-design

[jasmussen]

That is next level code archeology, thank you for contributing!

My instinct would be to remove these colors, to fix the code quality issue, but keep the visual as it appears in trunk. The main reason being: the contrast in the preview isn't very good, and it's not clear there's a huge value in those colors.

What do you think?

[t-hamano]

@jasmussen Thanks for the feedback!

My instinct would be to remove these colors, to fix the code quality issue, but keep the visual as it appears in trunk. The main reason being: the contrast in the preview isn't very good, and it's not clear there's a huge value in those colors.

I totally agree with the above 👍

[shimotmk]

@t-hamano
@jasmussen
Thank you for feedback!
I removed the customTextColor and it now looks the same as before.

[t-hamano]

Maybe attributes.fontSize isn't working either? If so, I think we can remove it now.

[shimotmk]

fontSize is theme-dependent.

In this screenshot, I removed the fontSize for One. and reduced the default font size for paragraphs.

I'll remove the example preview because I don't think theme-dependent attributes are good.

[t-hamano]

LGTM!

I think hardcoding the font size slug is certainly not a good idea, so it's better to remove it. If the text feels small, let's apply some px value instead in the follow-up.