-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Field Types: update storybook #71440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in def1ad5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17375135068
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would have been nice to ensure this was handled in git as a move instead of a separate add/delete, as it severs the git history and makes rebasing PRs much harder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I didn't think about that in this PR (didn't expect anyone working with this story), sorry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, maybe it was related to the way the PR was squashed into trunk rather than something you did. I see in the first commit it was handled as a move - 847bf62
Ignore me 😄
What?
Update the existing Field Types story so that each field type (text, integer, email, array, etc.) displays:
{id: '…', type: '…' }.{ id: '', type: '...', elements: [ ... ] }.{ id: '…', type: '…', Edit: 'checkbox' }.This affects both DataForm (the control displayed in regular layout) and DataViews (the control used for filtering).
Why?
So that we have documentation for people onboarding into DataForm/DataViews development (either contributing or consuming the libraries).
How
Editcontrol for the whole story, so that users can switch to using a different Edit control and see the effects it causes.Testing Instructions
Run the storybook locally (
npm install && npm run storybook:dev) and visit "DatViews > Field Types" story.