Skip to content

Conversation

@R1shabh-Gupta
Copy link
Contributor

@R1shabh-Gupta R1shabh-Gupta commented Sep 1, 2025

What?

Closes #71434

Removes unnecessary and invalid fields from accordion block.json files to clean up the block definitions and improve code quality.

Why?

The accordion blocks contained several unnecessary fields that were either unused, invalid:

  • Version numbers are not needed for core blocks
  • Some attributes were defined but never used in the code
  • Invalid support properties that don't exist in the block editor

This cleanup improves maintainability and reduces confusion for developers working with these blocks.

How?

The following fields were removed from the accordion block.json files:

Accordion block (core/accordion):

  • Removed allowedBlocks attribute

Accordion Content block (core/accordion-content):

  • Removed "version": "0.1.0" field
  • Removed supports.align

Accordion Header block (core/accordion-header):

  • Removed "version": "0.1.0" field
  • Removed invalid supports.border

Accordion Panel block (core/accordion-panel):

  • Removed "version": "0.1.0" field
  • Removed invalid supports.border

@R1shabh-Gupta R1shabh-Gupta marked this pull request as ready for review September 1, 2025 10:45
@github-actions
Copy link

github-actions bot commented Sep 1, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @dibyajit1234.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: dibyajit1234.

Co-authored-by: R1shabh-Gupta <[email protected]>
Co-authored-by: shail-mehta <[email protected]>
Co-authored-by: t-hamano <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added [Type] Code Quality Issues or PRs that relate to code quality [Block] Accordion Affects the Accordion Block labels Sep 1, 2025
Copy link
Member

@shail-mehta shail-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@t-hamano t-hamano added the props-bot Manually triggers Props Bot to ensure the list of props is up to date. label Sep 2, 2025
@github-actions github-actions bot removed the props-bot Manually triggers Props Bot to ensure the list of props is up to date. label Sep 2, 2025
@t-hamano t-hamano merged commit 6938b0b into WordPress:trunk Sep 2, 2025
79 of 85 checks passed
@github-actions github-actions bot added this to the Gutenberg 21.6 milestone Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Accordion Affects the Accordion Block [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accordion Blocks: Remove any unnecessary fields from block.json

4 participants