Skip to content

Expose ValidatedInputControl via privateAPIs #71451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
m1r0 wants to merge 3 commits into from
Closed

Expose ValidatedInputControl via privateAPIs #71451

m1r0 wants to merge 3 commits into from

Conversation

@m1r0
Copy link

@m1r0 m1r0 commented Sep 1, 2025 •
edited
Loading

What?

Related to this discussion, this PR exposes the ValidatedInputControl component via the privateAPIs.

Why?

The ValidatedInputControl component has a suffix, which is something we need on a few forms on Calypso.

@m1r0 m1r0 requested a review from ajitbohra as a code owner September 1, 2025 15:29
@github-actions
Copy link

github-actions bot commented Sep 1, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: m1r0 <[email protected]>
Co-authored-by: mirka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Sep 1, 2025
@github-actions
Copy link

github-actions bot commented Sep 1, 2025

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @m1r0! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@m1r0
Copy link
Author

m1r0 commented Sep 1, 2025

@mirka @oandregal Because you have context, can you give it a quick look?

@t-hamano t-hamano added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components labels Sep 2, 2025
mirka
mirka approved these changes Sep 2, 2025
View reviewed changes
Copy link
Member

@mirka mirka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@m1r0
Copy link
Author

m1r0 commented Sep 19, 2025

Looks like this was implemented in #71514. Closing...

@m1r0 m1r0 closed this Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mirka mirka mirka approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

No one assigned

Labels

First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@m1r0 @mirka @t-hamano