Fix popover scroll hook’s simultaneous scrolling #71468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stokesman
added
[Type] Bug
|
Size Change: +25 B (0%) Total Size: 1.92 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in a03652c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17417853664
|
stokesman
force-pushed
the
try/popover-scroll-defer-to-target
branch
from
b741317 to
a03652c
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @ccharel. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
6 tasks
t-hamano
approved these changes
Sep 4, 2025
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Thank you for the fix! This PR is working very well👍
Contributor
Author
|
Thank you for testing and the review Aki 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #70594
The hook now scrolls “through” the popover only if the
wheelevent’s target wasn’t within a scrollable container.Why?
Without this some popovers are scrolling their own content while simultaneously scrolling the editor canvas and causing unexpected movement of the popover.
How?
Testing Instructions
Screenshots or screencast
Screen.Recording.2025-07-02.at.9.53.13.PM.mov
fix-popover-scroll-simultaneous.mp4