Update datetime control to use calendar UI #71509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
added
the
[Feature] DataViews
44 tasks
Member
|
We're at least using a This matches the design specs, but I've noticed that interacting with the Screen.Recording.2025-09-04.at.17.47.26.mov |
Contributor
|
It's a tricky one. The native browser calendar UI includes some tools which may (or may not) be useful like clearing the value, and a shortcut to select 'today'. It's also arguably more ergonomic on mobile. But on balance I think your suggestion sounds reasonable. Curious what @mirka thinks. @jorgefilipecosta A couple of small feedbacks:
|
Member
We don't have a way to do this, both the panel and regular layout use the same underlying component declared by the field type ( |
Contributor
I suppose it doesn't matter, so long as a consumer can set up a date field in a |
Member
What I am hearing is that we need two controls, and we'd use one or another depending on the situation. We could have a:
Any of them can be the default for the How does this sound? |
Member
|
If I recall correctly, we were mainly forced to build the custom calendar to show more intuitive visuals for date ranges. A custom calendar isn't really necessary (nor particularly "better") for a single datetime value, IMO. So I'd also think just an I actually wouldn't recommend the custom calendar + |
Contributor
|
Reserving the calendar for ranges seems absolutely fine to me :) |
oandregal
force-pushed
the
update/datetime-control-calendar-ui
branch
from
f354bca to
9f22e6d
Compare
Member
|
Pushed changes to use the datetime-local: Screen.Recording.2025-09-12.at.09.47.30.movScreen.Recording.2025-09-12.at.09.37.31.mov |
Contributor
|
This seems fine as a starting point. I compared with the current date selection UX for posts/pages on trunk and I have to say there's something about the big calendar UI in the @mirka how would you feel about a control that is basically a combination of calendar + |
Member
Author
|
Thank you for pushing these enhancements @oandregal. |
Member
Sounds good. Maybe this should just be the standard pattern for when using the custom calendar components. Pair with a |
oandregal
approved these changes
Sep 13, 2025
jorgefilipecosta
force-pushed
the
update/datetime-control-calendar-ui
branch
from
9f22e6d to
8bdfe17
Compare
|
Size Change: +405 B (+0.02%) Total Size: 1.94 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8bdfe17. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17736657466
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the datetime control in DataViews to use a modern calendar-based UI, replacing the previous TimePicker implementation with a more intuitive interface.
Changes
Technical Details
Screenshots
Test Plan