Core Data: Always try to resolve entity permissions #71532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Performance
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -1 B (0%) Total Size: 1.93 MB
ℹ️ View Unchanged
|
Mamaduka
commented
Sep 7, 2025
Comment on lines
+413
to
+417
| // When requesting all fields, the list of results can be used to resolve | ||
| // the `getEntityRecord` selector in addition to `getEntityRecords`. | ||
| // See https://github.com/WordPress/gutenberg/pull/26575 | ||
| // Todo https://github.com/WordPress/gutenberg/issues/26629 | ||
| if ( ! query?._fields && ! query.context ) { |
Member
Author
There was a problem hiding this comment.
I'm working on #26629 and hope to remove these conditions entirely.
Member
Author
There was a problem hiding this comment.
Here's the first part, which should solve the additional requests problem - #71541.
Member
Author
There was a problem hiding this comment.
Here's the follow-up for this particular case - #71575.
Member
Author
|
@priethor, should we merge this? |
Member
Author
|
I'm going to merge this. PR just moves conditions around. |
Mamaduka
deleted the
update/core-data-collection-permissions-resolution
branch
talldan
pushed a commit
that referenced
this pull request
Sep 10, 2025
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: priethor <[email protected]>
adamsilverstein
pushed a commit
to adamsilverstein/gutenberg
that referenced
this pull request
Sep 11, 2025
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: priethor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up to #70738.
PR removes
queryargument conditions for entity permission resolutions. The data used for getting user permissions isn't contextual; it either exists or does not.It's better to review with the whitespace hidden.
Why?
Should improve performance for collection queries when the
contextquery argument is specified.Testing Instructions
wp-admin/site-editor.php?p=%2Fpage&layout=table.OPTIONSrequests for the/pagesendpoint.Test patch
Testing Instructions for Keyboard
Same.
Screenshots or screencast