Skip to content

DataViews grid layout: rounded corners for media #71543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oandregal merged 2 commits into from
Sep 8, 2025
Merged

DataViews grid layout: rounded corners for media #71543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efe73d8
Make sure children do not overflow the wrapper
oandregal Sep 8, 2025
e7b1347
Add changelog
oandregal Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/dataviews/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@
- DataForm: introduce a new `row` layout, check the README for details. [#71124](https://github.com/WordPress/gutenberg/pull/71124)
- Dataform: Add new `url` field type and field control. [#71518](https://github.com/WordPress/gutenberg/pull/71518)

### Bug Fixes

- DataViews grid layout: make sure media previews have rounded corners. [#71543](https://github.com/WordPress/gutenberg/pull/71543)

## 8.0.0 (2025-09-03)

### Breaking changes
Expand Down
1 change: 1 addition & 0 deletions packages/dataviews/src/dataviews-layouts/grid/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
aspect-ratio: 1/1;
background-color: $white;
border-radius: $radius-medium;
overflow: hidden;
Copy link
Contributor

@youknowriad youknowriad Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any "media" fields where we want scrollbars? Just asking to ensure we avoid regressions. Thinks like template previews could potentially fall in this category but not sure what the expectation there is.

Copy link
Member Author

@oandregal oandregal Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be fine if we want to do that (we don't in the current templates):

Screen.Recording.2025-09-08.at.16.28.44.mov

position: relative;

img {
Expand Down
Loading