DataViews: implement groupBy for list layout
#71548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
requested review from
jorgefilipecosta,
ntsekouras and
youknowriad
oandregal
added
[Type] Enhancement
|
Size Change: +126 B (+0.01%) Total Size: 1.93 MB
ℹ️ View Unchanged
|
Contributor
|
Nice. This looks good to me! |
youknowriad
reviewed
Sep 9, 2025
| groups.get( groupName )?.push( item ); | ||
| return groups; | ||
| }, new Map< string, typeof data >() ) | ||
| : null; |
Contributor
There was a problem hiding this comment.
Don't you think there's some internal utility or something like that here. Isn't this code duplicated in all layouts?
youknowriad
approved these changes
Sep 9, 2025
oandregal
force-pushed
the
add/group-by-dataviews-list
branch
from
382d02f to
2a948ed
Compare
|
Flaky tests detected in 2a948ed. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17588755316
|
talldan
pushed a commit
that referenced
this pull request
Sep 10, 2025
Co-authored-by: oandregal <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: jameskoster <[email protected]>
adamsilverstein
pushed a commit
to adamsilverstein/gutenberg
that referenced
this pull request
Sep 11, 2025
Co-authored-by: oandregal <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: jameskoster <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #57967
What?
Adds support to rendering the item list grouped by a field in the list layout.
Screen.Recording.2025-09-08.at.17.05.40.mov
Why?
It follows-up work to support the same in grid and table.
How?
Update the list layout to consider groupBy information, if present.
Testing Instructions
Open the storybook (
npm run storybook:dev), and visit the story "DataViews > DataViews > Group by Layout".