Navigation: Show inserter when Navigation Submenu block is selected #71578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
getdave
added
[Type] Bug
|
Size Change: +17 B (0%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
getdave
added
the
[Block] Submenu
Contributor
Author
|
Tests are failing because there are two inserters visible (in the submenu dropdown and alongside the main nav itself). |
getdave
force-pushed
the
feature/navigation-inserter-shows-for-submenu-selection
branch
from
ce41e71 to
8539d4a
Compare
|
Flaky tests detected in b4e1cf1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18167944737
|
scruffian
approved these changes
Sep 29, 2025
Contributor
scruffian
left a comment
scruffian
left a comment
There was a problem hiding this comment.
Left a few nits, but this looks good 🚢
| isImmediateParentOfSelectedBlock, | ||
| selectedBlockHasChildren, | ||
| isSelected, | ||
| hasSelectedDescendant, |
Contributor
There was a problem hiding this comment.
Would it be better to call this hasSelectedInnerBlock, so it matches the selector name?
Contributor
Author
There was a problem hiding this comment.
Hmmmm...I'm thinking about the logic here. Does it actually make sense? I'm wondering if there are edge cases here in terms of what's selected at what level of depth 🤔
Contributor
Author
There was a problem hiding this comment.
I thought about this some more and I think hasSelectedDescendant is actually the better name here.
The variable name should describe what it represents rather than which function was used to get it.
hasSelectedDescendant tells you "this block has a selected descendant somewhere in its hierarchy". hasSelectedInnerBlock might be confusing because it could sound like "does this block have inner blocks?" rather than "does this block have a selected descendant?"
| } ) => { | ||
| await pageUtils.pressKeys( 'ArrowDown' ); | ||
| await navigation.useBlockInserter(); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Copy/paste cos I put the "fix" in the wrong place initially.
getdave
commented
Sep 29, 2025
Previously, the Navigation block's inserter would only show when: - The Navigation block itself was selected, OR - A direct child of the Navigation block was selected This change adds support for showing the inserter when any descendant block is selected, including Navigation Submenu blocks. This allows users to add new navigation items at the top level even when working with submenus. Changes: - Added hasSelectedDescendant selector to check for any selected descendant - Updated renderAppender logic to include hasSelectedDescendant condition - Maintains all existing behavior while adding new functionality Fixes the issue where the Navigation block inserter was not visible when a Navigation Submenu block was selected.
getdave
force-pushed
the
feature/navigation-inserter-shows-for-submenu-selection
branch
from
c371489 to
b4e1cf1
Compare
getdave
deleted the
feature/navigation-inserter-shows-for-submenu-selection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes the issue where the Navigation block's inserter was not visible when a Navigation Submenu block was selected.
Why
Previously, the Navigation block's inserter would only show when:
This meant that when working with Navigation Submenu blocks (which are descendants, not direct children), users couldn't access the Navigation block's inserter to add new top-level navigation items.
How
hasSelectedDescendantselector to check for any selected descendant block at any nesting levelrenderAppenderlogic to includehasSelectedDescendantconditionTesting
Screenshots
[Screenshots to be added]
Breaking Changes
None - this is a pure enhancement that adds functionality without changing existing behavior.