Skip to content

DataForm: Sort day, month, and year of DateTime control according to locale #71580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
t-hamano wants to merge 2 commits into from
Closed

DataForm: Sort day, month, and year of DateTime control according to locale #71580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cd4650
DataForm: Sort day, month, and year of DateTime control according to …
t-hamano Sep 10, 2025
d8f9814
Add changelog
t-hamano Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/dataviews/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Unreleased

### Enhancements

- Dataform: Sort day, month, and year of `DateTime` control according to locale. [#/](https://github.com/WordPress/gutenberg/pull//)

### Breaking changes

- Remove `boolean` form control. Fields using `Edit: 'boolean'` must now use `Edit: 'checkbox'` or `Edit: 'toggle'` instead. Boolean field types now use checkboxes by default. [#71505](https://github.com/WordPress/gutenberg/pull/71505)
Expand Down
5 changes: 5 additions & 0 deletions packages/dataviews/src/dataform-controls/datetime.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/**
* WordPress dependencies
*/
import { _x } from '@wordpress/i18n';
import { BaseControl, TimePicker, VisuallyHidden } from '@wordpress/components';
import { useCallback } from '@wordpress/element';

Expand Down Expand Up @@ -55,6 +56,10 @@ export default function DateTime< Item >( {
currentTime={ typeof value === 'string' ? value : undefined }
onChange={ onChangeControl }
hideLabelFromVision
dateOrder={
/* translators: Order of day, month, and year. Available formats are 'dmy', 'mdy', and 'ymd'. */
_x( 'dmy', 'date order' ) as 'dmy' | 'mdy' | 'ymd'
}
/>
</fieldset>
);
Expand Down
Loading