-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Field API: add setValue
#71604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Field API: add setValue
#71604
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
a5c00fe
Initial implementation
straku e0ce670
TEMP: Change fixtures to use nested data
straku 6430200
Temp: Add story with nested data for DataForm
straku 423d60e
Change approach to typing an item and update usage
straku 3153f67
Fix tests
straku 898024a
Add setValue to boolean field in the stories
straku 4fdb8de
Allow `DeepPartial< Item >` to accept full `Item`
straku 508f710
Rely on `DeepPartial` in `setValue`
straku 1e15efe
Disable validation in filter controls
straku d1e45c8
Filters: prepare data and field
oandregal 3e0c027
Update custom Edit to match the DeepPartial shape of onChange
oandregal 2070e12
Use Item instead of DeepPartial<Item> as parameter to getValue and se…
oandregal d3467a3
Fix modal with nested data
oandregal cb4cdcd
Update story and fix the DeepPartial type definition.
oandregal e761011
Port new tests to existing test file
oandregal af025fb
Revert changes to fields
oandregal 9f33dbe
Adapt new places after rebase
oandregal ed9a157
Fix author field in DataForm story
straku 05fc231
Remove unused import, finer scope for useCallback dependencies
straku 2bf7cb0
Add comment for DeepPartial type
straku 6ffd2ec
Doc changes
straku 684463a
Use setValue for custom validation functions item argument
straku a26aebd
Update readme after validation changes
straku ad84488
Story: return partial, not item
oandregal f848c91
Do not make password required in a custom rule
oandregal 661c3f0
Filters: setValue should return a partial
oandregal 6e1cfa7
Revert "Update readme after validation changes"
straku eb9be76
Use full item for custom validation functions
straku c69e9d2
Fix wrong conflict resolution
straku 131bc7e
Fix onChange for date related controls
straku ed0226e
Improve internal types used in date control: DateRange
oandregal 8c15df5
Improve internal types used in Date control: DateRelative
oandregal ad9aed6
Datetime: fix relative filter
oandregal 5d332a3
Integer control: improve internal types and checks
oandregal 1f7b912
ToggleControl: fix validation
oandregal 28fc311
Add changelog entry
oandregal bfa4bdc
DataForm panel: fix modal (changes accumulate)
oandregal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix author field in DataForm story
- Loading branch information
commit ed9a157a9456508c36916d34abf8406bfd7bee18
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@straku I pushed 83db790 as per our conversations. It seems to work nicely, and so we can continue working with
Itemdata (instead of partials) as parameter togetValue/setValue.