Skip to content

Conversation

@ockham
Copy link
Contributor

@ockham ockham commented Sep 15, 2025

What?

Remove code owners of the Comments, Comment Template, and Image blocks from the CODEOWNERS file.

Why?

They're no longer working on Gutenberg and shouldn't be pinged for reviews.

@ockham ockham self-assigned this Sep 15, 2025
@ockham ockham requested a review from desrosj as a code owner September 15, 2025 09:41
@ockham ockham added the [Type] Code Quality Issues or PRs that relate to code quality label Sep 15, 2025
@github-actions
Copy link

github-actions bot commented Sep 15, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ockham <[email protected]>
Co-authored-by: sirreal <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: cbravobernal <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


# Blocks
/packages/block-library @ajitbohra @fabiankaegy
/packages/block-library/src/gallery
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also delete this line? There are no owners for the Gallery.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of lines with no code owners. That could be a separate cleanup.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines without a code owner allows do have meaning:

# In this example, @octocat owns any file in the `/apps`
# directory in the root of your repository except for the `/apps/github`
# subdirectory, as its owners are left empty. Without an owner, changes
# to `apps/github` can be made with the approval of any user who has
# write access to the repository.
/apps/ @octocat
/apps/github

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're using code owners as a notification system, rather than as a way to determine who can approve what.

@cbravobernal cbravobernal enabled auto-merge (squash) September 15, 2025 09:44
@github-actions
Copy link

Flaky tests detected in add44f4.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17728779586
📝 Reported issues:

@cbravobernal cbravobernal merged commit bd4ea3d into trunk Sep 15, 2025
83 of 85 checks passed
@cbravobernal cbravobernal deleted the update/codeowners-image-block branch September 15, 2025 10:18
@github-actions github-actions bot added this to the Gutenberg 21.7 milestone Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants