-
Notifications
You must be signed in to change notification settings - Fork 4.6k
CODEOWNERS: Remove some block code owners #71657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
|
||
| # Blocks | ||
| /packages/block-library @ajitbohra @fabiankaegy | ||
| /packages/block-library/src/gallery |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also delete this line? There are no owners for the Gallery.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of lines with no code owners. That could be a separate cleanup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines without a code owner allows do have meaning:
# In this example, @octocat owns any file in the `/apps`
# directory in the root of your repository except for the `/apps/github`
# subdirectory, as its owners are left empty. Without an owner, changes
# to `apps/github` can be made with the approval of any user who has
# write access to the repository.
/apps/ @octocat
/apps/github
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're using code owners as a notification system, rather than as a way to determine who can approve what.
|
Flaky tests detected in add44f4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17728779586
|
What?
Remove code owners of the Comments, Comment Template, and Image blocks from the CODEOWNERS file.
Why?
They're no longer working on Gutenberg and shouldn't be pinged for reviews.