Skip to content

Block Editor: fix BlockSwitcher to prevent transforms on reusable blocks #71661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mamaduka merged 3 commits into from
Sep 16, 2025
Merged

Block Editor: fix BlockSwitcher to prevent transforms on reusable blocks #71661

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
258a731
fix: remove transforms for synced patterns
shrivastavanolo Sep 15, 2025
00641db
refactor: code quality
shrivastavanolo Sep 16, 2025
785399a
refactor: code quality
shrivastavanolo Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/block-editor/src/components/block-switcher/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,14 +102,16 @@ function BlockSwitcherDropdownMenuContents( {
selectForMultipleBlocks( transformedBlocks );
}
/**
* The `isTemplate` check is a stopgap solution here.
* The `isSynced` check is a stopgap solution here.
* Ideally, the Transforms API should handle this
* by allowing to exclude blocks from wildcard transformations.
*/
const isSingleBlock = blocks.length === 1;
const isTemplate = isSingleBlock && isTemplatePart( blocks[ 0 ] );
const isSynced =
isSingleBlock &&
( isTemplatePart( blocks[ 0 ] ) || isReusableBlock( blocks[ 0 ] ) );
const hasPossibleBlockTransformations =
!! possibleBlockTransformations.length && canRemove && ! isTemplate;
!! possibleBlockTransformations?.length && canRemove && ! isSynced;
const hasPossibleBlockVariationTransformations =
!! blockVariationTransformations?.length;
const hasPatternTransformation = !! patterns?.length && canRemove;
Expand Down
Loading