Skip to content

Conversation

@ockham
Copy link
Contributor

@ockham ockham commented Sep 15, 2025

What?

Add a block-agnostic version of the block_bindings_supported_attributes_{$block_type} filter (first introduced by #71389).

Why?

See #71662 (comment). In a nutshell, it's quickly becoming cumbersome to add block bindings support for various attributes of different blocks in the WP compat layer code.

@ockham ockham marked this pull request as ready for review September 15, 2025 12:33
@github-actions
Copy link

github-actions bot commented Sep 15, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ockham <[email protected]>
Co-authored-by: gziolo <[email protected]>
Co-authored-by: cbravobernal <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me 👍🏻

Copy link
Contributor

@cbravobernal cbravobernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Flaky tests detected in a77bf2e.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17733178985
📝 Reported issues:

@ockham
Copy link
Contributor Author

ockham commented Sep 16, 2025

Thank you both!

@ockham ockham merged commit 15c2f07 into trunk Sep 16, 2025
82 of 83 checks passed
@ockham ockham deleted the add/block-bindings-supported-attributes-block-agnostic-filter branch September 16, 2025 08:59
@github-actions github-actions bot added this to the Gutenberg 21.7 milestone Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants