Block Inspector: Add content tab for section blocks #71714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Enhancement
|
Size Change: +48 B (0%) Total Size: 1.95 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 000cd63. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17852510360
|
aaronrobertshaw
force-pushed
the
refactor/block-inspector
branch
from
0b18c3b to
6e368dd
Compare
aaronrobertshaw
force-pushed
the
add/block-inspector-content-tab
branch
from
46939ba to
5a8cada
Compare
Contributor
Author
|
This has been rebased and fixed after changes introduce in #71708. |
aaronrobertshaw
force-pushed
the
add/block-inspector-content-tab
branch
from
5a8cada to
df32ac1
Compare
Contributor
Author
|
This is still depending on #71608 landing; however, while rough, this could be ready for some early feedback. |
aaronrobertshaw
requested review from
andrewserong,
ramonjd,
talldan and
tellthemachines
aaronrobertshaw
force-pushed
the
add/block-inspector-content-tab
branch
2 times, most recently
from
9e3bdbc to
20f844a
Compare
aaronrobertshaw
force-pushed
the
add/block-inspector-content-tab
branch
from
20f844a to
f9cd1c4
Compare
aaronrobertshaw
changed the title
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
|
With #71608 merged, I'll mark this ready for review. |
talldan
approved these changes
Sep 19, 2025
Contributor
There was a problem hiding this comment.
All the testing steps worked well for me, and the code is looking nice and tidy.
I left one small comment about a potential bug if this and another PR are merged around the same time. The only way it's reproducible is by cherry-picking commits from another PR, but it's a small fix, so should be easy to handle before merging.
edit: Only other thing to note is that the code isn't behind the contentOnly patterns experiment flag, but when turning off the experiment I couldn't find anywhere that it shows up (and it works well anyway). It does also work in write mode, but that's also an experiment.
packages/block-editor/src/components/inspector-controls-tabs/use-inspector-controls-tabs.js
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks for the thorough testing and review @talldan 🙇 I've made the preemptive fix for preventing dual display of the list and content tabs in 000cd63.
This is one thing I did mean to get clarified. As you said, it does work for sections in both the contentOnly patterns and write mode experiments so might be ok to keep as is. One benefit to this might be keeping the UI as consistent as possible. I'm definitely open to gating this behind the contentOnly pattern experiment. I can make those updates early next week. |
Member
|
Just gave this a manual test. Great improvement. The tab is working as expected for me for template parts, query block and patterns. If it's all good with @talldan then |
Contributor
|
Yep, the changes still test well for me. 🚢 |
Contributor
Author
Contributor
|
I personally think this one is ok to merge without the experiment flag. |
Contributor
Author
Ok, I'll stash the updates I was working on. The fact that this only really impacts two in-progress experiments means we should have some leeway to iterate as needed |
adamsilverstein
pushed a commit
to adamsilverstein/gutenberg
that referenced
this pull request
Sep 22, 2025
Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: talldan <[email protected]> Co-authored-by: ramonjd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #71626
Depends on: #71608
Introduces a Content tab for section blocks that displays content-only descendant blocks via quick navigation
Why?
There are ongoing explorations to simplify the editing of patterns using
contentOnlymode by default for them. Part of these efforts is to also allow editing of descendant blocks via a content panel in the inspector. For more complex patterns, the number of descendant blocks can result in a very crowded inspector. This PR introduces a "content" tab to provided more real estate and better separation of content, setting, and style controls.How?
Introduces a new content tab that is similar in approach to the existing styles tab.
Testing Instructions
Screenshots or screencast