Skip to content

Block Comments: Improve focus management for comment interactions #71814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
t-hamano merged 12 commits into from
Oct 10, 2025
Merged

Block Comments: Improve focus management for comment interactions #71814

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f80f6fe
Focus comments Input field
karthick-murugan Sep 22, 2025
99720f6
Feedback changes
karthick-murugan Oct 3, 2025
e978d78
Feedback changes
karthick-murugan Oct 3, 2025
eca7f00
Feedback changes
karthick-murugan Oct 6, 2025
ed20db4
Feedback changes
karthick-murugan Oct 6, 2025
64e31ad
Implement utils functionality
karthick-murugan Oct 6, 2025
10735eb
Index file conflict issue
karthick-murugan Oct 7, 2025
e4808ae
Js Lint issues
karthick-murugan Oct 7, 2025
5c74d03
JS Linting issues
karthick-murugan Oct 7, 2025
ee364e4
Merge branch 'trunk' into comments-input-field-focus
karthick-murugan Oct 10, 2025
a6e2d81
Removing focus changes
karthick-murugan Oct 10, 2025
8669814
Style changes
karthick-murugan Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Index file conflict issue
  • Loading branch information
@karthick-murugan
karthick-murugan committed Oct 7, 2025
commit 10735eb2c99e5cd83fc5890551ebc2b430031a58
4 changes: 0 additions & 4 deletions packages/editor/src/components/collab-sidebar/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,14 +269,10 @@ export default function CollabSidebar() {
onClick={ () => {
openCollabBoard();
if ( commentSidebarRef?.current && currentThread ) {
<<<<<<< HEAD
focusCommentThread( currentThread.id, commentSidebarRef.current );
=======
focusCommentThread(
currentThread.id,
commentSidebarRef.current
);
>>>>>>> b62b21031e (Implement utils functionality)
}
} }
thread={ currentThread }
Expand Down
1 change: 1 addition & 0 deletions packages/editor/src/components/collab-sidebar/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@
overflow: hidden;
clip-path: inset(50%);
background: $white !important;

&:focus {
top: $grid-unit-10;
right: $grid-unit-10;
Expand Down
Loading