-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Accordion Panel: Fixes block visibility when the panel is collapsed #71866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accordion Panel: Fixes block visibility when the panel is collapsed #71866
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @minaldiwan. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@theminaldiwan, I think this PR is the same as #71845, and I can see conflicts in this PR. You'll probably need to sync your local repository with the upstream branch before submitting a PR. |
|
@theminaldiwan Thanks for the PR. This PR also have Conflicts. Could you please resolve this Conflicts? |
b853e78 to
3b2cf23
Compare
|
How about updating .wp-block-accordion-panel {
&[inert],
&[aria-hidden="true"] {
display: none;
// Prevent blockGap from Accordion Content block from adding extra margin between accordions.
margin-block-start: 0;
}
}That is, remove |
|
Hi @t-hamano
I update style in latest commit. |
t-hamano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
What?
Closes #71806
Why?
When collapsed panel and we added already padding, border or box-shadow to panel then its appearance not looks proper.
How?
Using style hide the visibility of panel when it is collapsed.
or we can apply (Dimensions) and (Border & Shadow) inline styles to child element of wp-block-accordion-panel
Testing Instructions
Screencast
Screen.Recording.2025-09-23.at.6.34.55.PM.mov