Skip to content

Icons: Switch to SVG icons, autobuild React elements #71878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcsf merged 4 commits into from
Oct 3, 2025
Merged

Icons: Switch to SVG icons, autobuild React elements #71878

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3e4ee2d
Icons: Switch to SVG icons, autobuild React elements
mcsf Sep 21, 2025
42f158d
Teach lint tools to handle these generated files
mcsf Oct 3, 2025
5dbbff6
Icons: Remove `clean` script
mcsf Oct 3, 2025
b32e6d1
Update CHANGELOG.md
mcsf Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Icons: Remove clean script
  • Loading branch information
@mcsf
mcsf committed Oct 3, 2025
commit 5dbbff6d08e9a7992a0751878486f656a1e64ac2
3 changes: 1 addition & 2 deletions packages/icons/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@
},
"scripts": {
"prelint": "npm run build",
Copy link
Contributor

@youknowriad youknowriad Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why is this in "prelint" and not "prebuild" or directly in "build" or something like that?

Copy link
Contributor Author

@mcsf mcsf Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prebuild is too late. That's what I tried first. Because it's not just TS that needs resolvable import paths: ESLint needs it too.

Copy link
Contributor

@youknowriad youknowriad Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see

"build": "node bin/generate-library",
"clean": "git clean -Xfq src/library"
"build": "node bin/generate-library"
}
}
Loading