-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Image block: Conditionally remove empty <figcaption>
#71893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+110
−2
Merged
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
b756c18
Image block: Conditionally remove empty <figcaption>
ockham a4244ff
Remove <figcaption> node if caption is empty
ockham 5041974
:zipper_mouth_face: WPCS
ockham ca3f45d
Add test coverage
ockham 03dcbe9
Make it self-contained
ockham 4904b9f
Use Reflection to get access to serialize_token() method on WP < 6.9
ockham 15504f3
Cosmetics
ockham 8e7a87d
Typo
ockham 2d00ba6
Better use subclass and overloading to fix visibility
ockham 44b5297
WPCS STFU
ockham bc3d638
Add unit test coverage for ID override in classname
ockham 5da4679
Excise figcaption
ockham 5d5224d
WPCS
ockham 3e93e77
Add unit test to make sure figcaption is kept when not empty
ockham b8f92f8
Get tests to pass
ockham f502ef1
Use Tag Processor
ockham c71102b
Fix WPCS warnings
ockham 262995b
Consider comments inside of <figcaption> as empty
ockham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Image block: Conditionally remove empty <figcaption>
- Loading branch information
commit b756c185bfc2eda922418738b1b38557ec6763ea
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.