Skip to content

Add width block supports under dimensions. #71905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronrobertshaw merged 12 commits into from
Nov 25, 2025
Merged

Add width block supports under dimensions. #71905

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
769bb54
Add width and height block supports under dimensions.
ryanwelcher Sep 25, 2025
89ed419
Render width and height on the front end.
ryanwelcher Sep 25, 2025
55402fe
PHPCS fixes
ryanwelcher Sep 25, 2025
36a526d
PHPCS whitespace fixes.
ryanwelcher Sep 25, 2025
105a250
Remove the height support to split it out to a new PR.
ryanwelcher Sep 25, 2025
ab2591f
Remove support for cover block used in testing.
ryanwelcher Sep 25, 2025
257c2fe
Fix and complete width block support
aaronrobertshaw Oct 22, 2025
e9ace72
Fix appearance tools test
aaronrobertshaw Oct 24, 2025
2aaaea4
Add missing selectors config for dimensions
aaronrobertshaw Oct 30, 2025
5ba8dde
Add changelog
aaronrobertshaw Nov 5, 2025
a609173
Clean up unnused phpcs:ignore
aaronrobertshaw Nov 24, 2025
63a31d3
Add some unit tests for application of width styles
aaronrobertshaw Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
PHPCS fixes
  • Loading branch information
@ryanwelcher @aaronrobertshaw
ryanwelcher authored and aaronrobertshaw committed Nov 24, 2025
commit 55402fea4cffa4ab3ac725fe39d78d4c8a3ad08b
4 changes: 2 additions & 2 deletions lib/block-supports/dimensions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ function gutenberg_apply_dimensions_support( $block_type, $block_attributes ) {
function gutenberg_render_dimensions_support( $block_content, $block ) {
$block_type = WP_Block_Type_Registry::get_instance()->get_registered( $block['blockName'] );
$block_attributes = ( isset( $block['attrs'] ) && is_array( $block['attrs'] ) ) ? $block['attrs'] : array();
$has_dimensions_support = block_has_support( $block_type, 'dimensions', false );
$has_dimensions_support = block_has_support( $block_type, 'dimensions', false );

if (
! $has_dimensions_support ||
Expand All @@ -111,7 +111,7 @@ function gutenberg_render_dimensions_support( $block_content, $block ) {
}

// Add width and height values.
$dimensions_block_styles['width'] = $block_attributes['style']['dimensions']['width'] ?? null;
$dimensions_block_styles['width'] = $block_attributes['style']['dimensions']['width'] ?? null;
$dimensions_block_styles['height'] = $block_attributes['style']['dimensions']['height'] ?? null;

$styles = gutenberg_style_engine_get_styles( array( 'dimensions' => $dimensions_block_styles ) );
Expand Down
4 changes: 2 additions & 2 deletions packages/style-engine/src/class-wp-style-engine.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ final class WP_Style_Engine {
'spacing' => '--wp--preset--spacing--$slug',
),
),
'width' => array(
'width' => array(
'property_keys' => array(
'default' => 'width',
),
Expand All @@ -219,7 +219,7 @@ final class WP_Style_Engine {
'spacing' => '--wp--preset--spacing--$slug',
),
),
'height' => array(
'height' => array(
'property_keys' => array(
'default' => 'height',
),
Expand Down