New block: Playlist #71992
Closed
New block: Playlist #71992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
requested review from
a team,
Mamaduka,
jameskoster,
jasmussen,
luisherranz,
t-hamano and
youknowriad
ntsekouras
added
New Block
Contributor
|
@ntsekouras, Do you know this PR has already been submitted? |
|
Size Change: +4.13 kB (+0.21%) Total Size: 1.96 MB
ℹ️ View Unchanged
|
Contributor
Author
I had no idea. I didn't see anyone assigned to the issue yesterday and assigned myself and started working on that PR. I missed it.. 😢 |
Contributor
|
Flaky tests detected in ff10264. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18158466540
|
Contributor
|
@t-hamano @ntsekouras I'm not available to work on it, I have not even been able to read all the questions from the last review or re-base it 💔 |
Contributor
|
@carolinan It's ok, someone with the time may take over the PR 🙂 |
Contributor
|
Well, I miss you all 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #71026
Resolves: #805
This PR add a new
Playlistblock. The current designs in the issue might be outdated, so design feedback is required. Currently I tried to implement onlyaudioplaylist, but we might want to explore about a video playlist.Questions + Notes
audiofiles don't haveimage/posterinfo AFAIK. Should we have a placeholder for each attachment and upload from there? If yes, should we add this field in media library edit?hide the playlist(items)? Should we have a toggle somewhere to show it? Should we update any other UI (for example the list contains x items).Tasks
includevalue change). Investigate if there is a current way to do it with core-data or how to solve thisTesting Instructions
PlaylistblockScreenshots or screencast
Noting that the screenshots are with border and padding applied to the specific block instance. Since users can add their own styles, the default ones should not include anything.