Skip to content

Template activation: ignore templates not associated with active theme #72029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ellatrix merged 4 commits into from
Oct 3, 2025
Merged

Template activation: ignore templates not associated with active theme #72029

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f7e6219
Template activation: lock templates to themes
ellatrix Oct 2, 2025
b02a0cf
server side
ellatrix Oct 2, 2025
2f097e1
lint
ellatrix Oct 3, 2025
0e3e18a
Add e2e test
ellatrix Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
server side
  • Loading branch information
@ellatrix
ellatrix committed Oct 2, 2025
commit b02a0cf5e9c306c5bd7c9d817034fc043acd6b68
11 changes: 10 additions & 1 deletion lib/compat/wordpress-6.9/template-activate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,16 @@
continue;
}

$templates[] = _build_block_template_result_from_post( $post );
$template = _build_block_template_result_from_post( $post );

// Ensure the active templates are associated with the active theme.
// See _build_block_template_object_from_post_object.
if ( $template->theme !== get_stylesheet() ) {

Check failure on line 234 in lib/compat/wordpress-6.9/template-activate.php

View workflow job for this annotation

GitHub Actions / PHP coding standards 

Use Yoda Condition checks, you must.
$remaining_slugs[] = $slug;
continue;
}

$templates[] = $template;
}

// For any remaining slugs, use the static template.
Expand Down
Loading