Build: Support watching SVG icons to generate TSX #72087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up of #71878 As of #71878, the library of icons in the Icons package consists of plain SVG files, from which a build step generates TSX files and an index.ts. However, this generation only happened once upon invoking `npm run dev` (and `npm run build`). This commit adds support for watching changes to those SVG files and regenerating accordingly.
mcsf
added
[Type] Build Tooling
|
Size Change: -144 B (-0.01%) Total Size: 1.96 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Co-authored-by: Aki Hamano <[email protected]>
|
Flaky tests detected in f11fa95. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18281003284
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up of #71878
As of #71878, the library of icons in the Icons package consists of plain SVG files, from which a build step generates TSX files and an index.ts.
However, this generation only happened once upon invoking
npm run dev(andnpm run build). This pull request adds support for watching changes to those SVG files and regenerating accordingly.Why?
Better developer experience whenever an icon is being actively tweaked.
How?
bin/packages/):src/**/*.svgas a possible match for source filesbuildSVG) specifically for icons which calls the preexisting generation functionsTo do
Testing Instructions
npm run dev. Once it settles:packages/icons/src/library/*.svg. Ensure that the watcher-builder sees this change and generates the corresponding TSX file. Ensure that the icon has changed in the UI.packages/icons/src/library/*.svg. Ensure that the watcher-builder reports this as an error.git add, then restartdev) and ensure that a TSX file is now generated.npm run build. It should work just as described in Icons: Switch to SVG icons, autobuild React elements #71878.Screenshots or screencast
icons-watcher.mov