Extract Page and NavigableRegion components to an admin-ui package #72106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
requested review from
ajitbohra,
fabiankaegy,
gziolo and
juanmaguitar
as code owners
youknowriad
added
the
[Type] Code Quality
|
Size Change: +749 B (+0.04%) Total Size: 1.96 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
add/admin-ui
branch
from
24ba0ba to
c0f7899
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
force-pushed
the
add/admin-ui
branch
from
c0f7899 to
beb230f
Compare
jameskoster
reviewed
Oct 7, 2025
| { title } | ||
| </Heading> | ||
| ) } | ||
| { breadcrumbs } |
Contributor
There was a problem hiding this comment.
Breadcrumbs sounds like a very handy feature as we think about admin pages with potentially deep structures like settings. How does this render? Should breadcrumbs appear before the title, with the title acting as the 'current item' in the trail?
Contributor
Author
There was a problem hiding this comment.
The idea here is that it replaces the title, you provide one or the other, not both
youknowriad
force-pushed
the
add/admin-ui
branch
from
beb230f to
00ef7ba
Compare
|
Flaky tests detected in 92cb0f1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18313585705
|
Contributor
|
Looks like this PR broke the scrollbars in the dataviews screens. If a view has overflow, it's no longer scrollable: 
Whereas for views that don't fill the screen, the footer isn't sticky anymore: 
|
sidharthpandita1
pushed a commit
to sidharthpandita1/gutenberg
that referenced
this pull request
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Within the Site Editor, there are multiple components that are used to compose admin routes and pages. When we open extensibility for third-party plugins to build routes within the site editor or for third-party plugins that want to build plugins that register wp-admin pages that look like site editor pages, they need access to these components to avoid duplicating styles, behavior.
Also, we have other kind of UIs that are not specific to a given route that are more "admin ui" and generic enough to be in a package like #71948
It feels like an "admin-ui" package would be a good solution for this. Also this is a bundled package which means we can adjust it over time while third-parties can benefit from it as an npm dependency.
Testing Instructions