-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Provide "collaborative-editing" post type support #72147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +39 B (0%) Total Size: 2.12 MB
ℹ️ View Unchanged
|
|
Recently, we began declaring editor-specific feature supports as sub-properties of top-level Here's the latest example - #71682. |
My only reservation is future behavior. In theory, it is possible for a post type to lack |
If that were the case, then the top-level support key would make more sense. The |
5343f57 to
984c700
Compare
984c700 to
75021fd
Compare
|
One question I have here is that I have trouble understanding how this support works. Imagine users being in a session (say in the site editor) where some post types support collaborative editing but others not, and they do modifications to both kind of post types, what's the expected behavior here? |
Great question! To me, this question centers around edit locks and making sure they are correctly implemented and respected by every editing mode. In general, I would want every editing mode to follow these rules:
Correct me if I'm wrong, but AFAIK the current site editor does not set or respect edit locks. Unintentional overrides are already a problem there. I'm not deeply familiar with the how the site editor works so I'm not sure if I'm suggesting something that will be a huge undertaking. Are there other current examples of multi-entity-editing besides the site editor? In our plugin, we currently disable the experiment on the site editor, partially for this reason. |
This is true, even in the post editor it is true. That said when some things are "collaborative" it becomes a bit harder to reason about, because editors have the capacity to open multiple entities from multiple post types at the same time. I guess in other words, it would have been simpler if we had basic collaborative editing for all entities by default (even if the merging is not optimized properly) |
|
Closing the PR for this approach, as changing the loaded context to We can work to add |
What?
Provide a new "collaborative-editing" post type support.
Why?
A new post type support adds support for collaborative editing to posts and pages by default and allows custom post types to opt in to collaborative editing.
How?
Use the
enabledflag on the entity sync config to signal whether an entity supports collaborative editing.Testing Instructions
Testing Instructions for Keyboard
Note: This provider uses requests to admin-ajax.php for signaling and the initial connection is delayed.
Screenshots or screencast
pr-1.mov