Block Comments: Always show comment menu item #72153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
commented
Oct 8, 2025
| aria-haspopup="dialog" | ||
| > | ||
| { _x( 'Comment', 'Add comment button' ) } | ||
| { __( 'Comment' ) } |
Contributor
Author
There was a problem hiding this comment.
Nit: I removed the context, as I feel it's redundant.
|
Size Change: +2 B (0%) Total Size: 1.96 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 9ba565e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18336529910
|
Contributor
|
Nice work. I was too slow to test this, but I found a couple of other things that I tracked in #72157. Let me know if those make sense. |
sidharthpandita1
pushed a commit
to sidharthpandita1/gutenberg
that referenced
this pull request
Oct 10, 2025
Co-authored-by: t-hamano <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: jasmussen <[email protected]> Co-authored-by: adamsilverstein <[email protected]> Co-authored-by: joedolson <[email protected]> Co-authored-by: kjnanda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #71906
Note: This PR doesn't fix the a11y issues mentioned in #71906. The issues related to a11y should be addressed in #71814 separately.
Why?
A conditionally rendered menu item can be confusing.
How?
Renders the comment menu item, whether or not it has a blockCommentId. As a small refactor, I renamed the component.
Testing Instructions
Screenshots or screencast