Skip to content

Remove core/entity binding in favour of post and term data bindings. Apply to Nav blocks. #72165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
getdave merged 21 commits into from
Oct 17, 2025
Merged

Remove core/entity binding in favour of post and term data bindings. Apply to Nav blocks. #72165

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
8de830e
Block bindings: prefer attributes over context; add link; remove core…
getdave Oct 6, 2025
4e4e8c1
Add clear comments for backwards compat
getdave Oct 13, 2025
fda4b5f
Use correct sources
getdave Oct 13, 2025
8da866f
Don't use setter for navigation bindings
getdave Oct 13, 2025
6a67da0
Clean up Nav block conditionals
getdave Oct 13, 2025
2fe149f
Tone down backward compat comments
getdave Oct 13, 2025
fe31a16
Reduce comment verbosity in PHP
getdave Oct 13, 2025
5ae5757
Use correct error handling
getdave Oct 13, 2025
cb5c56b
Avoid dding clientId arg
getdave Oct 13, 2025
3e398c2
Fix Submenu using wrong binding
getdave Oct 15, 2025
455bacc
Fix https://github.com/WordPress/gutenberg/pull/72165\#pullrequestrev…
getdave Oct 15, 2025
1b0511f
Tweak comments
getdave Oct 15, 2025
57d6fc5
Remove count from term count string
getdave Oct 16, 2025
befad83
Improve consistency of use-entity-binding
getdave Oct 16, 2025
b981a70
Handle all binding types when clearing url
getdave Oct 16, 2025
8a47fd9
Add backport changelog
ockham Oct 16, 2025
fe1289b
Fix bug with sidebar Link field not clearing
getdave Oct 16, 2025
37cba74
Match tests to new implementation
getdave Oct 16, 2025
92e7bfd
await error notice in link control test
jeryj Oct 16, 2025
4c60e00
Fix faulty entity binding clearing logic
getdave Oct 17, 2025
7bc97f3
Tweak entity binding tests again
getdave Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Avoid dding clientId arg
  • Loading branch information
@getdave
getdave committed Oct 17, 2025
commit cb5c56b3f15ca23fdfcc96bd861e261cc09dc438
3 changes: 2 additions & 1 deletion packages/editor/src/bindings/post-data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,8 @@ export default {

return true;
},
getFieldsList( { select, context, clientId } ) {
getFieldsList( { select, context } ) {
const clientId = select( blockEditorStore ).getSelectedBlockClientId();
// Deprecated, will be removed after 6.9.
return getPostDataFields( select, context, clientId );
},
Expand Down