Build: Move packages that output script modules to v2 pipeline #72173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@sirreal Not sure if you're the one I should be ping but how do I test that the a11y script module is working properly? |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +4 B (0%) Total Size: 2.07 MB
ℹ️ View Unchanged
|
Member
#65123 has some testing instructions. I'm trying to follow them but they depend on some Interactivity API client side navigation and seem to be outdated. I'll try to test and provide instructions.
|
Member
|
I don't think this is working correctly. Here's what I've done to test. Enqueue a script module that depends on import { speak } from '@wordpress/a11y';
const time = 1_000;
let i = 0;
setTimeout(() => {
setInterval(() => {
speak(i++ < 1 ? `Count: ${i}` : String(i));
}, time);
}, time * 2);Observe this on the browser console: [...document.querySelectorAll('[aria-live]')].map(e=>`${e.ariaLive}: ${JSON.stringify(e.textContent)}`)With this branch of Gutenberg active (I built the branch with
If I disable Gutenberg, it works as expected. I see the live regions update and a screen reader reads them aloud. |
youknowriad
requested review from
dmsnell,
ellatrix,
gziolo,
kevin940726,
mmtr and
swissspidy
as code owners
youknowriad
force-pushed
the
update/move-script-modules-to-v2
branch
from
78c1375 to
ac4f931
Compare
Contributor
Author
|
Thanks @sirreal good catch, it should be fixed with the latest commit. |
youknowriad
force-pushed
the
update/move-script-modules-to-v2
branch
from
3c53ef5 to
7d0a76c
Compare
youknowriad
added
the
No Core Sync Required
|
Flaky tests detected in 90ed5bc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18354608064
|
sidharthpandita1
pushed a commit
to sidharthpandita1/gutenberg
that referenced
this pull request
Oct 10, 2025
…ress#72173) Co-authored-by: youknowriad <[email protected]> Co-authored-by: sirreal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #72032
What?
This continues the work on the v2 build pipeline and expands the number of packages built by the v2 pipeline.
The current PR focus on packages like "a11y" that use the "wpScriptModuleExports" flag to generate script modules to be registered in WordPress.
Testing instructions
npm run devlocally, changes some files in the said packages.