Skip to content

Background Block Support: Fix unit test HTML escaping after core change #72233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
talldan wants to merge 5 commits into from
Closed

Background Block Support: Fix unit test HTML escaping after core change #72233

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2d1d007
Fix unit test HTML escaping after core change
talldan Oct 10, 2025
f9274af
Huh?
talldan Oct 10, 2025
f600b47
Revert "Huh?"
talldan Oct 10, 2025
510f0b1
Use assertEqualHTML
talldan Oct 10, 2025
0c23b03
Switch to assertSame to match core test
talldan Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions phpunit/block-supports/background-test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ public function test_background_block_support( $theme_name, $block_name, $backgr

$actual = gutenberg_render_background_support( $wrapper, $block );

$this->assertEquals(
$this->assertSame(
$expected_wrapper,
$actual,
'Background block wrapper markup should be correct'
Expand All @@ -133,7 +133,7 @@ public function data_background_block_support() {
'url' => 'https://example.com/image.jpg',
),
),
'expected_wrapper' => '<div class="has-background" style="background-image:url(&#039;https://example.com/image.jpg&#039;);background-size:cover;">Content</div>',
'expected_wrapper' => '<div class="has-background" style="background-image:url(&apos;https://example.com/image.jpg&apos;);background-size:cover;">Content</div>',
'wrapper' => '<div>Content</div>',
),
'background image style is applied when backgroundImage is a string' => array(
Expand All @@ -145,7 +145,7 @@ public function data_background_block_support() {
'background_style' => array(
'backgroundImage' => "url('https://example.com/image.jpg')",
),
'expected_wrapper' => '<div class="has-background" style="background-image:url(&#039;https://example.com/image.jpg&#039;);background-size:cover;">Content</div>',
'expected_wrapper' => '<div class="has-background" style="background-image:url(&apos;https://example.com/image.jpg&apos;);background-size:cover;">Content</div>',
'wrapper' => '<div>Content</div>',
),
'background image style with contain, position, attachment, and repeat is applied' => array(
Expand All @@ -162,7 +162,7 @@ public function data_background_block_support() {
'backgroundSize' => 'contain',
'backgroundAttachment' => 'fixed',
),
'expected_wrapper' => '<div class="has-background" style="background-image:url(&#039;https://example.com/image.jpg&#039;);background-position:50% 50%;background-repeat:no-repeat;background-size:contain;background-attachment:fixed;">Content</div>',
'expected_wrapper' => '<div class="has-background" style="background-image:url(&apos;https://example.com/image.jpg&apos;);background-position:50% 50%;background-repeat:no-repeat;background-size:contain;background-attachment:fixed;">Content</div>',
'wrapper' => '<div>Content</div>',
),
'background image style is appended if a style attribute already exists' => array(
Expand All @@ -176,7 +176,7 @@ public function data_background_block_support() {
'url' => 'https://example.com/image.jpg',
),
),
'expected_wrapper' => '<div class="wp-block-test has-background" style="color: red;background-image:url(&#039;https://example.com/image.jpg&#039;);background-size:cover;">Content</div>',
'expected_wrapper' => '<div class="wp-block-test has-background" style="color: red;background-image:url(&apos;https://example.com/image.jpg&apos;);background-size:cover;">Content</div>',
'wrapper' => '<div class="wp-block-test" style="color: red">Content</div>',
),
'background image style is appended if a style attribute containing multiple styles already exists' => array(
Expand All @@ -190,7 +190,7 @@ public function data_background_block_support() {
'url' => 'https://example.com/image.jpg',
),
),
'expected_wrapper' => '<div class="wp-block-test has-background" style="color: red;font-size: 15px;background-image:url(&#039;https://example.com/image.jpg&#039;);background-size:cover;">Content</div>',
'expected_wrapper' => '<div class="wp-block-test has-background" style="color: red;font-size: 15px;background-image:url(&apos;https://example.com/image.jpg&apos;);background-size:cover;">Content</div>',
'wrapper' => '<div class="wp-block-test" style="color: red;font-size: 15px;">Content</div>',
),
'background image style is not applied if the block does not support background image' => array(
Expand Down
Loading