Skip to content

Enable block "click through" overlay for Navigation block in contentOnly mode #72248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
getdave wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Enable block "click through" overlay for Navigation block in contentOnly mode #72248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/block-editor/src/store/selectors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2986,11 +2986,21 @@ export const __unstableGetVisibleBlocks = createSelector(
);

export function __unstableHasActiveBlockOverlayActive( state, clientId ) {
const blockName = getBlockName( state, clientId );
const editingMode = getBlockEditingMode( state, clientId );

// Temporary: Allow Navigation block to have overlay in contentOnly mode
// to promote the off-canvas editing experience.
// See: https://github.com/WordPress/gutenberg/issues/71757
// TODO: Replace with block support mechanism in future iteration.
const isNavigationInContentOnly =
blockName === 'core/navigation' && editingMode === 'contentOnly';

// Prevent overlay on blocks with a non-default editing mode. If the mode is
// 'disabled' then the overlay is redundant since the block can't be
// selected. If the mode is 'contentOnly' then the overlay is redundant
// since there will be no controls to interact with once selected.
if ( getBlockEditingMode( state, clientId ) !== 'default' ) {
if ( editingMode !== 'default' && ! isNavigationInContentOnly ) {
return false;
}

Expand Down
Loading